Skip to content

Update providers structure #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2023
Merged

Update providers structure #29

merged 3 commits into from
Aug 2, 2023

Conversation

@tylerhutcherson
Copy link
Collaborator

@tylerhutcherson tylerhutcherson commented Jul 31, 2023 •
edited
Loading

Update redisvl Providers to Vectorizers >>

redisvl/
  vectorize/
    __init__.py
    base.py
    text/
        __init__.py
        huggingface.py
        openai.py
    # image/

Also creates classes for HFTextVectorizer and OpenAITextVectorizer.

@tylerhutcherson tylerhutcherson marked this pull request as ready for review August 1, 2023 15:40
@tylerhutcherson tylerhutcherson requested a review from Spartee August 1, 2023 15:40
Spartee
Spartee reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but looks like it's failing looking for the API key. IT's a secret so that should work.

@tylerhutcherson
Copy link
Collaborator Author

tylerhutcherson commented Aug 2, 2023

Minor comments, but looks like it's failing looking for the API key. IT's a secret so that should work.

Interesting. Can we confirm the str used? The tests pass locally for me with OPENAI_API_KEY set personally.

@tylerhutcherson tylerhutcherson force-pushed the update-providers-CU-86855rbnv branch from 011e6c6 to cb42ef5 Compare August 2, 2023 15:45
@tylerhutcherson tylerhutcherson force-pushed the update-providers-CU-86855rbnv branch from 1c69d85 to 0f9ef9e Compare August 2, 2023 20:02
@tylerhutcherson
Copy link
Collaborator Author

tylerhutcherson commented Aug 2, 2023

Minor comments, but looks like it's failing looking for the API key. IT's a secret so that should work.

Interesting. Can we confirm the str used? The tests pass locally for me with OPENAI_API_KEY set personally.

Resolved!

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #29 (45e32c6) into main (8bdb4b3) will not change coverage.
The diff coverage is 84.61%.

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files          11       11           
  Lines         559      559           
=======================================
  Hits          494      494           
  Misses         65       65
Files Changed Coverage Δ
redisvl/llmcache/semantic.py 88.15% <60.00%> (ø)
redisvl/vectorize/base.py 79.16% <100.00%> (ø)
redisvl/vectorize/text/__init__.py 100.00% <100.00%> (ø)
redisvl/vectorize/text/huggingface.py 86.36% <100.00%> (ø)
redisvl/vectorize/text/openai.py 86.11% <100.00%> (ø)

@tylerhutcherson tylerhutcherson merged commit 6a38262 into main Aug 2, 2023
@tylerhutcherson tylerhutcherson deleted the update-providers-CU-86855rbnv branch August 2, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Spartee Spartee Spartee left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tylerhutcherson @codecov-commenter @Spartee